Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] New Microsoft.Compute/sshPublicKey #2673

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

shawntmeyer
Copy link
Contributor

This is a new module to generate a ssh Public Key. I cannot generate a status badge because I am unable to register the new workflow after resetting my main branch to the upstream commit, but the static tests and deployment tests worked successfully.

This resource is strange in that it really has no value. You cannot use this resource to generate an actual public key value. You must provide the public key string in the publicKey parameter if you want the resource to contain an actual public key.

The common test uses a deployment script to generate a temporary ssh public key via the 'New-AzSshKey' cmdlet and grab the public key string from this object to provide it as the publicKey parameter value.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Update to documentation

Checklist

  • [X ] I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer requested a review from a team as a code owner February 9, 2023 04:31
@AlexanderSehr AlexanderSehr changed the title [Module] New Microsoft.Compute/sshPublicKey [Modules] New Microsoft.Compute/sshPublicKey Feb 9, 2023
shawntmeyer and others added 8 commits February 10, 2023 09:07
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…ies.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…st.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Feb 11, 2023
@eriqua eriqua added enhancement New feature or request wait for author labels Feb 28, 2023
@AlexanderSehr AlexanderSehr merged commit ce13120 into Azure:main Apr 18, 2023
3 checks passed
@shawntmeyer shawntmeyer deleted the sshPublicKey branch April 18, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request wait for author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants