Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Virtual Network Gateway Module API Version (2022-07-01) #2685

Merged
merged 3 commits into from
Feb 11, 2023

Conversation

ahmadabdalla
Copy link
Contributor

closes #2669

Description

Updated virtual network gateway module to the latest API version. And added new properties and natRules child module, and updated test cases to leverage new properties

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: VirtualNetworkGateways

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working enhancement New feature or request [cat] modules category: modules labels Feb 11, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.10.0 milestone Feb 11, 2023
@ahmadabdalla ahmadabdalla self-assigned this Feb 11, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review February 11, 2023 03:09
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner February 11, 2023 03:09
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) February 11, 2023 03:10
@ahmadabdalla ahmadabdalla merged commit 8edacc2 into main Feb 11, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2669_vnetGwApi branch February 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Network: VirtualNetworkGateways
2 participants