Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Reduce parameter names to necessary baseline #2686

Merged
merged 8 commits into from
Feb 13, 2023
Merged

[Modules] Reduce parameter names to necessary baseline #2686

merged 8 commits into from
Feb 13, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Feb 12, 2023 •
edited

Description

  • As described in the issue, this PR intends to incrementally remove redundant elements from parameter names
  • Further had to update the API version of Host Pools as the pipeline would otherwise fail (and used the chance to add a min test)

Note: Where applicable also fixed parameters (e.g. incorrect passthru to runbook child in Automation Account module)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ApiManagement: Service
Automation: AutomationAccounts
CDN: Profiles
Compute: ProximityPlacementGroups
Compute: Galleries
Databricks: Workspaces
DesktopVirtualization: HostPools
DesktopVirtualization: Scalingplans
DesktopVirtualization: Workspaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Feb 12, 2023
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Feb 12, 2023
@AlexanderSehr AlexanderSehr linked an issue Feb 12, 2023 that may be closed by this pull request
[Feature Request]: Reduce module parameter-names to their name without the modules identifier #2677
Closed
@AlexanderSehr AlexanderSehr added the bug Something isn't working label Feb 12, 2023
@github-actions
Copy link

github-actions bot commented Feb 12, 2023 •
edited

Test Results

  1 files    1 suites   24s ⏱️
47 tests 46 ✔️ 1 💤 0 ❌
51 runs  49 ✔️ 2 💤 0 ❌

Results for commit 2ada281.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review February 12, 2023 18:59
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner February 12, 2023 18:59
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) February 12, 2023 19:00
MariusStorhaug
MariusStorhaug approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AlexanderSehr AlexanderSehr merged commit 2fa6585 into main Feb 13, 2023
@AlexanderSehr AlexanderSehr deleted the users/alsehr/2677_paramNames branch February 13, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Reduce module parameter-names to their name without the modules identifier
2 participants
@AlexanderSehr @MariusStorhaug