[Modules] Updated VPN Sites Module to the latest API Version (2022-07-01)

[ahmadabdalla]

Closes #2709

Description

Updated VPN Sites to latest module

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

• Bugfix (non-breaking change which fixes an issue)

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (readme)
• I did format my code

[github-actions]

Test Results

  1 files  ±  0    1 suites  ±0   34s ⏱️ -3s
46 tests ±  0  44 ✔️ ±  0  2 💤 ±0  0 ❌ ±0 
50 runs   - 16  47 ✔️  - 12  3 💤  - 4  0 ❌ ±0 

Results for commit 7a88be4. ± Comparison against base commit ac97d3b.

This pull request removes 46 and adds 46 tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Insights/dataCollectionRules] used resource type [dataCollectionRules] should use one of the recent API version(s). Currently using [2021-09-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Insights/dataCollectionRules] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Insights/dataCollectionRules] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
…

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Network/vpnSites] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Network/vpnSites] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Network/vpnSites] used resource type [vpnSites] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
…

This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Insights/dataCollectionRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Insights/dataCollectionRules] JSON test files in the .test folder should be valid json

/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/vpnSites] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/vpnSites] JSON test files in the .test folder should be valid json

♻️ This comment has been updated with latest results.