Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Support for configuring backup retention policies for Azure SQL Database #2811

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Feb 17, 2023

Testing of #2802

Original PR description:


Description

The change adds support for configuring short and long term backup retention policies for Azure SQL Databases.

Default values are fetched from a deployment through portal without defining any policy.
retentionDays: 7
diffBackupIntervalInHours: 24

Pipeline references

Pipeline
Sql - Servers

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

… SQL Database (#2802)

The change adds support for configuring short and long term backup retention policies for Azure SQL Databases.

Default values are fetched from a deployment through portal without defining any policy.
retentionDays: 7
diffBackupIntervalInHours: 24

---------

Co-authored-by: Thomas Flenstad <thomas@flenstad.com>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Marius Storhaug <marstor@hotmail.com>
@github-actions
Copy link

github-actions bot commented Feb 17, 2023

Test Results

    1 files  ±    0      1 suites  ±0   4m 6s ⏱️ - 1m 6s
385 tests  - 183  377 ✔️  - 181    8 💤  - 2  0 ±0 
393 runs   - 183  383 ✔️  - 181  10 💤  - 2  0 ±0 

Results for commit 74fba4b. ± Comparison against base commit ea7a419.

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug marked this pull request as ready for review February 17, 2023 10:26
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner February 17, 2023 10:26
@MariusStorhaug MariusStorhaug merged commit 1e0db7b into main Feb 17, 2023
@MariusStorhaug MariusStorhaug deleted the ex_users/thofle/azsqlBackupPolicies branch February 17, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants