Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Log Analytics Workspace - added support for tables, dataExports, identity #2822

Merged
merged 22 commits into from
Feb 21, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Feb 20, 2023

Description

This PR resolves #2640 and extends the Log Analytics Workspace module (Microsoft.OperationalInsights/workspaces). Following functionality has been added/updated:

  • Update module's API versions
  • Adding support for child resources:
  • Adding support for a resource identity

Pipeline references

Pipeline
OperationalInsights - Workspaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Feb 20, 2023

Test Results

    1 files      1 suites   3m 17s ⏱️
307 tests 299 ✔️   8 💤 0
315 runs  305 ✔️ 10 💤 0

Results for commit e5abcc2.

♻️ This comment has been updated with latest results.

@krbar krbar changed the title [Modules] Log Analytics - added support for tables, dataExports, identity [Modules] Log Analytics Workspace - added support for tables, dataExports, identity Feb 20, 2023
@krbar krbar marked this pull request as ready for review February 20, 2023 07:42
@krbar krbar requested a review from a team as a code owner February 20, 2023 07:42
@krbar krbar enabled auto-merge (squash) February 20, 2023 07:53
krbar and others added 5 commits February 20, 2023 15:29
…eploy.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…eploy.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…eploy.bicep

Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
@krbar krbar merged commit 98820cd into main Feb 21, 2023
@krbar krbar deleted the users/krbar/lawTables branch February 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants