Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Microsoft.Compute/disks: API versions, image sku, new properties #2831

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Feb 21, 2023

Description

This PR resolves #2827 and introduces following improvements:

  • replaced a non-existing source image sku for the "Import" test case:
    • old: Windows-10 - 19h2-evd
    • new: Windows-11 - win11-21h2-avd
  • updated API versions of the test deployments
  • updated API versions of the disk resource and related improvements
    • added new disk sku: PremiumV2_LRS
    • added new, non-breaking parameters:
      • architecture
      • optimizedForFrequentAttach

Note: two additional parameters included in the api version 2022-07-02 were not included in the module update as they appear to be in preview and/or are not supported in the test subscription and could not be tested: disk.supportedCapabilities.diskControllerTypes and PerformancePlus

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute - Disks

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@krbar krbar linked an issue Feb 21, 2023 that may be closed by this pull request
@krbar krbar marked this pull request as ready for review February 21, 2023 14:54
@krbar krbar requested a review from a team as a code owner February 21, 2023 14:54
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@krbar krbar merged commit 271802a into main Feb 23, 2023
@krbar krbar deleted the users/krbar/2827-compute-disks-fix branch February 23, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Compute - Disks
2 participants