Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update Container Instances API version and CMK implementation #2845

Merged
merged 8 commits into from
Mar 1, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Feb 27, 2023

Description

Update to latest non preview API version
Added identity property to CMK implementation as required by the update API
Requires validation from ACI resource experienced

Resource property before removal
image

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerInstance - ContainerGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua linked an issue Feb 27, 2023 that may be closed by this pull request
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires an update / cleanup of the Wiki

@github-actions
Copy link

Test Results

  1 files  ±    0    1 suites  ±0   30s ⏱️ -45s
45 tests  - 116  44 ✔️  - 115  1 💤  - 1  0 ±0 
57 runs   - 108  53 ✔️  - 109  4 💤 +1  0 ±0 

Results for commit 064e392. ± Comparison against base commit fbe9cee.

This pull request removes 161 and adds 45 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories/integrationRuntimes] used resource type [factories/integrationRuntimes] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories/managedVirtualNetworks/managedPrivateEndpoints] used resource type [factories/managedVirtualNetworks/managedPrivateEndpoints] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories/managedVirtualNetworks] used resource type [factories/managedVirtualNetworks/managedPrivateEndpoints] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories/managedVirtualNetworks] used resource type [factories/managedVirtualNetworks] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [factories/integrationRuntimes] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [factories/managedVirtualNetworks/managedPrivateEndpoints] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [factories/managedVirtualNetworks] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [factories] should use one of the recent API version(s). Currently using [2018-06-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DataFactory/factories] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.ContainerInstance/containerGroups] used resource type [containerGroups] should use one of the recent API version(s). Currently using [2022-09-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.ContainerInstance/containerGroups] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.ContainerInstance/containerGroups] If delete lock is implemented, the template should have a lock parameter with an empty default value
…
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.DataFactory/factories/managedVirtualNetworks/managedPrivateEndpoints] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.DataFactory/factories] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.ContainerInstance/containerGroups] JSON test files in the .test folder should be valid json

@eriqua eriqua marked this pull request as ready for review February 28, 2023 14:12
@eriqua eriqua requested a review from a team as a code owner February 28, 2023 14:12
@eriqua eriqua enabled auto-merge (squash) February 28, 2023 14:12
@eriqua eriqua added bug Something isn't working enhancement New feature or request [cat] modules category: modules labels Feb 28, 2023
@eriqua
Copy link
Contributor Author

eriqua commented Feb 28, 2023

Requires an update / cleanup of the Wiki

@AlexanderSehr done

@eriqua eriqua merged commit f4f6f82 into main Mar 1, 2023
@eriqua eriqua deleted the users/erika/fix-aci branch March 1, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] ContainerInstance - ContainerGroups
3 participants