Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Simplify roleAssignment implementation for Resource Group #2855

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Mar 1, 2023

Description

Simplify the inputs required for RG RBAC. As the resource ID is already provided in the scope of the deployment, the default is to get the current resourceGroup id.

Pipeline references

Pipeline
Resources - ResourceGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug added the [cat] modules category: modules label Mar 1, 2023
@MariusStorhaug MariusStorhaug self-assigned this Mar 1, 2023
@MariusStorhaug MariusStorhaug changed the title [Module] Simplify the RG RBAC [Module] Simplify roleAssignment implementation for Resource Group Mar 1, 2023
@MariusStorhaug MariusStorhaug changed the title [Module] Simplify roleAssignment implementation for Resource Group [Module]: Simplify roleAssignment implementation for Resource Group Mar 1, 2023
@MariusStorhaug MariusStorhaug marked this pull request as ready for review March 1, 2023 08:36
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner March 1, 2023 08:36
@MariusStorhaug MariusStorhaug changed the title [Module]: Simplify roleAssignment implementation for Resource Group [Modules] Simplify roleAssignment implementation for Resource Group Mar 1, 2023
@MariusStorhaug MariusStorhaug merged commit 72e1db9 into main Mar 1, 2023
@MariusStorhaug MariusStorhaug deleted the mast/feat/rg_rbac_cleanup branch March 1, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants