Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] PSRule - Fix Rule Azure.Resource.UseTags #2860

Merged
merged 59 commits into from
Mar 10, 2023

Conversation

fabmas
Copy link
Member

@fabmas fabmas commented Mar 2, 2023

Description

[PSRule] Fix Rule Azure.Resource.UseTags
close #2666

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
.Platform: Library PSRule pre-flight validation

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

fabmas and others added 18 commits March 3, 2023 16:13
…e/dependencies.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…n/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…n/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…n/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…mon/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…t/common/deploy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
….test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
….test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
….test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…loy.test.bicep

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Test Results

  1 files  ±0    1 suites  ±0   29s ⏱️ ±0s
48 tests +4  46 ✔️ +3  1 💤 ±0  1 +1 
56 runs  +4  52 ✔️ +3  3 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit d83c2bf. ± Comparison against base commit 05fc574.

This pull request removes 44 and adds 48 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.OperationsManagement/solutions] used resource type [solutions] should use one of the recent API version(s). Currently using [2015-11-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] If delete lock is implemented, the template should have a lock parameter with an empty default value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.OperationsManagement/solutions] Location output should be returned for resources that use it
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.SignalRService/webPubSub] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.SignalRService/webPubSub] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.SignalRService/webPubSub] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.SignalRService/webPubSub] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.SignalRService/webPubSub] used resource type [webPubSub] should use one of the recent API version(s). Currently using [2021-10-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.SignalRService/webPubSub] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.SignalRService/webPubSub] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.SignalRService/webPubSub] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.SignalRService/webPubSub] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.SignalRService/webPubSub] CUA ID deployment should be present in the template
…
This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.OperationsManagement/solutions] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.SignalRService/webPubSub] JSON test files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@elanzel elanzel enabled auto-merge (squash) March 9, 2023 12:31
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@elanzel elanzel merged commit 419e56a into main Mar 10, 2023
@elanzel elanzel deleted the users/fabmas_2666_psrules_tags branch March 10, 2023 11:03
@BernieWhite
Copy link

BernieWhite commented Apr 3, 2023

There might be an typo with Microsoft.ApiManagementservice/eventGridFilters should be Microsoft.ApiManagement/service/eventGridFilters.

See:

- Microsoft.ApiManagementservice/eventGridFilters

Also maybe this one:

- Microsoft.AADDomainServices/oucontainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PSRule] Fix Rule Azure.Resource.UseTags
5 participants