Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated SKU options and added generation parameter for VNET Gateways #2875

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[Modules] Updated SKU options and added generation parameter for VNET Gateways #2875

merged 1 commit into from
Mar 8, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Mar 7, 2023 •
edited

Closes #2347

Description

Updated the VNET Gateway Module with more SKUs and Generation parameter

Pipeline
Network - VirtualNetworkGateways

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Mar 7, 2023
@ahmadabdalla ahmadabdalla self-assigned this Mar 7, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review March 7, 2023 06:05
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner March 7, 2023 06:05
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) March 7, 2023 06:06
@ahmadabdalla ahmadabdalla changed the title Updated SKU options and added generation parameter for VNET Gateways [Modules] Updated SKU options and added generation parameter for VNET Gateways Mar 7, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.10.0 milestone Mar 7, 2023
@ahmadabdalla ahmadabdalla merged commit e82f165 into main Mar 8, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2347_vnetGw branch March 8, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
Release v0.10.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add SKU and Generation parameters for Virtual Network Gateway
2 participants
@ahmadabdalla @AlexanderSehr