Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] managedClusters - Fix a bug for addonprofiles #2880

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Mar 8, 2023

Description

When deploying the current version of managedCluster and you enable some of the addons, and later remove them using the module, you get an error for reconfiguring addonProfiles as the format is incorrectly formatted. This PR fixes this where its sets the expected value of null on config for the profiles which are disabled.

Pipeline references

Pipeline
ContainerService - ManagedClusters

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug changed the title [Modules]: managedCluster - Fix a bug for addonprofiles [Modules] managedClusters - Fix a bug for addonprofiles Mar 8, 2023
@MariusStorhaug MariusStorhaug added [cat] modules category: modules bug Something isn't working labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Test Results

  1 files    1 suites   45s ⏱️
86 tests 85 ✔️ 1 💤 0
94 runs  91 ✔️ 3 💤 0

Results for commit 5ed46a1.

@MariusStorhaug MariusStorhaug marked this pull request as ready for review March 8, 2023 13:00
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner March 8, 2023 13:00
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) March 8, 2023 13:06
@MariusStorhaug MariusStorhaug merged commit 8283179 into main Mar 8, 2023
@MariusStorhaug MariusStorhaug deleted the users/mast/managedClusterFixAddonProfiles branch March 8, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants