Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Removed child resource that may not be used in the applied context #2999

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Mar 15, 2023

Description

The configuration child may not be used this way as documented e.g. here.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DbForMySQL - FlexibleServers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner March 15, 2023 19:40
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Mar 15, 2023
@github-actions
Copy link

Test Results

    1 files  ±0      1 suites  ±0   58s ⏱️ -31s
121 tests  - 2  118 ✔️  - 3  3 💤 +1  0 ±0 
129 runs   - 2  124 ✔️  - 3  5 💤 +1  0 ±0 

Results for commit cd8909d. ± Comparison against base commit b86667d.

This pull request removes 123 and adds 121 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts/capacityPools/volumes] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts/capacityPools/volumes] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [netAppAccounts/capacityPools] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts/capacityPools] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools/volumes] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts/capacityPools] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts] used resource type [netAppAccounts] should use one of the recent API version(s). Currently using [2022-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.NetApp/netAppAccounts] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers/databases] used resource type [flexibleServers/databases] should use one of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers/firewallRules] used resource type [flexibleServers/firewallRules] should use one of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [flexibleServers/databases] should use one of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [flexibleServers/firewallRules] should use one of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [flexibleServers] should use one of the recent API version(s). Currently using [2021-12-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.DBforMySQL/flexibleServers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.DBforMySQL/flexibleServers/databases] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.DBforMySQL/flexibleServers/databases] All non-required parameters in template file should not have description that start with "Required."
…
This pull request removes 2 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.NetApp/netAppAccounts/capacityPools/volumes] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.NetApp/netAppAccounts] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.DBforMySQL/flexibleServers/databases] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.DBforMySQL/flexibleServers/firewallRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.DBforMySQL/flexibleServers] JSON test files in the .test folder should be valid json

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) March 19, 2023 18:45
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit e31cc84 into main Mar 23, 2023
@AlexanderSehr AlexanderSehr deleted the users/alsehr/removeConfigFlex branch March 23, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants