Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Virtual Machine module: adding support for a custom computer name #3036

Merged
merged 10 commits into from
May 1, 2023
Merged

[Modules] Virtual Machine module: adding support for a custom computer name #3036

merged 10 commits into from
May 1, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Mar 21, 2023 •
edited

Description

This PR resolves #2988 and adds an option to select a computer name, which is different from the name of the Azure VM resource:

  • new parameter computerName added
  • vmComputerNamesTransformation removed as the case transformation can be achieved with the computerName parameter

Pipeline references

Pipeline
Compute - VirtualMachines

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@krbar krbar linked an issue Mar 21, 2023 that may be closed by this pull request
[Feature Request]: Allow custom computerName for virtual machines #2988
Closed
@krbar krbar self-assigned this Mar 21, 2023
@krbar
Copy link
Contributor Author

krbar commented Mar 21, 2023

Waiting for #3032 to be merged...

@AlexanderSehr AlexanderSehr marked this pull request as ready for review April 13, 2023 15:53
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner April 13, 2023 15:53
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Apr 13, 2023
@krbar krbar marked this pull request as draft April 28, 2023 16:45
@krbar krbar marked this pull request as ready for review April 28, 2023 16:45
@krbar
Copy link
Contributor Author

krbar commented Apr 28, 2023

All suggested improvements are implemented, ready for review again.

@krbar krbar enabled auto-merge (squash) April 28, 2023 16:55
eriqua
eriqua approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@krbar krbar merged commit 6742701 into main May 1, 2023
25 checks passed
@krbar krbar deleted the users/krbar/2988-vm-custom-computername branch May 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@krbar krbar

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow custom computerName for virtual machines
3 participants
@krbar @AlexanderSehr @eriqua