Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Environment] Remove implementation retrieving deploymentSpId #3082

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Apr 3, 2023

Description

Closes #3081

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute - ProximityPlacementGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added documentation Improvements or additions to documentation enhancement New feature or request [cat] pipelines category: pipelines [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Apr 3, 2023
@eriqua eriqua marked this pull request as ready for review April 3, 2023 11:09
@eriqua eriqua requested a review from a team as a code owner April 3, 2023 11:09
@eriqua eriqua enabled auto-merge (squash) April 3, 2023 11:38
@eriqua eriqua changed the title [CI environment] Remove implementation retrieving deploymentSpId [CI Environment] Remove implementation retrieving deploymentSpId Apr 3, 2023
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I've also ran a couple of pipelines to validate. Thanks @eriqua

@eriqua eriqua merged commit 621658f into main Apr 5, 2023
38 of 39 checks passed
@eriqua eriqua deleted the users/erikag/deploymentspid branch April 5, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] pipelines category: pipelines documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Remove deploymentSpId implementation
2 participants