Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Cosmos DB SQL API containers child module with new parameters #3103

Merged
merged 5 commits into from
Apr 29, 2023
Merged

[Modules] Updated Cosmos DB SQL API containers child module with new parameters #3103

merged 5 commits into from
Apr 29, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Apr 10, 2023 •
edited

Description

Closes #2885
Closes #2886

Pipeline references

Pipeline
DocumentDB - DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Apr 10, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.11.0 milestone Apr 10, 2023
@ahmadabdalla ahmadabdalla self-assigned this Apr 10, 2023
@ahmadabdalla ahmadabdalla changed the title Added new properties for sql DB and containers child module [Modules] Updated Cosmos DB SQL API containers child module with new parameters Apr 10, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review April 10, 2023 22:14
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner April 10, 2023 22:14
@ahmadabdalla ahmadabdalla mentioned this pull request Apr 11, 2023
Closed
@AlexanderSehr AlexanderSehr marked this pull request as draft April 17, 2023 08:46
@ahmadabdalla ahmadabdalla marked this pull request as ready for review April 17, 2023 09:45
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) April 29, 2023 07:25
@ahmadabdalla ahmadabdalla merged commit 057691a into main Apr 29, 2023
19 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/2885_CosmosSql branch April 29, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules enhancement New feature or request
Projects
Backlog
Status: Done
Milestone
Release v0.11.0
2 participants
@ahmadabdalla @AlexanderSehr