Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Create module for Microsoft.Network/dnsForwardningRulesets #3149

Merged
merged 52 commits into from
Jul 12, 2023
Merged

[Modules] Create module for Microsoft.Network/dnsForwardningRulesets #3149

merged 52 commits into from
Jul 12, 2023

Conversation

JPEasier
Copy link
Contributor

New Module Microsoft.Network/dnsForwardningRulesets
submodules:

  • dnsForwardningRulesets/forwardingRules
  • dnsForwardningRulesets/virtualNetworkLinks

Due to an underlying API issue with naming of locations I updated the deployment location in the settings.yml file from West Europe to westeurope - see error messege

Pipeline references

Pipeline
Network - DNS Forwarding Rulesets

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@JPEasier JPEasier added the [cat] modules category: modules label Apr 25, 2023
@JPEasier JPEasier added this to the Release v0.11.0 milestone Apr 25, 2023
@JPEasier JPEasier requested a review from a team as a code owner April 25, 2023 15:12
@JPEasier JPEasier self-assigned this Apr 25, 2023
JPEasier and others added 5 commits June 14, 2023 10:02
@JPEasier @AlexanderSehr
Update modules/Microsoft.Network/dnsForwardingRulesets/deploy.bicep
c3551e8 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@JPEasier @AlexanderSehr
Update modules/Microsoft.Network/dnsForwardingRulesets/deploy.bicep
038afca 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@JPEasier @AlexanderSehr
Update modules/Microsoft.Network/dnsForwardingRulesets/forwardingRule…
7166145 
…s/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@JPEasier @AlexanderSehr
Update modules/Microsoft.Network/dnsForwardingRulesets/forwardingRule…
4bfab6c 
…s/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@JPEasier
remove old module
daaac9a
AlexanderSehr
AlexanderSehr requested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a main.test.bicep in the root of the .test folder as per the other modules. This was merged into main after you opened your PR.

@AlexanderSehr AlexanderSehr merged commit 60511ec into main Jul 12, 2023
6 of 8 checks passed
@AlexanderSehr AlexanderSehr deleted the users/jpeasier/dnsForwardingRulesets branch July 12, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@JPEasier JPEasier

Labels
[cat] modules category: modules
Projects
None yet
Milestone
Release v0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JPEasier @AlexanderSehr