Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] New child module for Synapse workspace Integration Runtime #3194

Merged
merged 17 commits into from
May 16, 2023

Conversation

tyconsulting
Copy link
Contributor

@tyconsulting tyconsulting commented May 11, 2023

Description

New module for Synapse workspace Integration Runtime addressing issue #3191

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Synapse - Workspaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@tyconsulting tyconsulting marked this pull request as ready for review May 11, 2023 11:01
@tyconsulting tyconsulting requested a review from a team as a code owner May 11, 2023 11:01
eriqua and others added 8 commits May 12, 2023 09:16
…md files - part 2/2 (Azure#3189)

* update cross references in modules

* update references in ado pipelines

* update references in authorization readme

* regenerate all readmes

* constructs

* constructs remove deploy.bicep

* constructs rename folders

* remove microsoft. occurrences from workflows

* replace readme in gh triggers

* fix cross reference and regenerate readmes

* remove comments

* autorization readme

* utility docs

* set readme docs

* utility example docs

* rename custom folders and update utility

* digitalTwinsInstance

* web

* Update modules/Web/sites/slots/config--authsettingsv2/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/slots/config--appsettings/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/config--authsettingsv2/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/config--appsettings/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--eventGrid/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--serviceBus/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--eventHub/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…md files - part 2/2 (Azure#3189)

* update cross references in modules

* update references in ado pipelines

* update references in authorization readme

* regenerate all readmes

* constructs

* constructs remove deploy.bicep

* constructs rename folders

* remove microsoft. occurrences from workflows

* replace readme in gh triggers

* fix cross reference and regenerate readmes

* remove comments

* autorization readme

* utility docs

* set readme docs

* utility example docs

* rename custom folders and update utility

* digitalTwinsInstance

* web

* Update modules/Web/sites/slots/config--authsettingsv2/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/slots/config--appsettings/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/config--authsettingsv2/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/Web/sites/config--appsettings/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--eventGrid/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--serviceBus/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update modules/DigitalTwins/digitalTwinsInstances/endpoints--eventHub/README.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…pt (Azure#3197)

* Addressed latest name changes

* Push updated Readme file(s)

---------

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
@eriqua eriqua changed the title New module for Synapse workspace Integration Runtime [Modules] New module for Synapse workspace Integration Runtime May 11, 2023
@tyconsulting
Copy link
Contributor Author

hey @ahmadabdalla could you review this PR for me?

@tyconsulting
Copy link
Contributor Author

hi @eriqua please have another look. thanks

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels May 12, 2023
@tyconsulting
Copy link
Contributor Author

@AlexanderSehr updated and re-ran the tests, the badge is linked to the latest test run. please have another look

@AlexanderSehr AlexanderSehr merged commit 286c71a into Azure:main May 16, 2023
3 checks passed
@AlexanderSehr
Copy link
Contributor

Awesome @tyconsulting. Thank you very much for your contribution :)

@tyconsulting tyconsulting deleted the feature/synapse-ir branch May 21, 2023 10:48
@eriqua eriqua changed the title [Modules] New module for Synapse workspace Integration Runtime [Modules] New child module for Synapse workspace Integration Runtime Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants