Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Add AppInsights Diagnostic Settings #3277

Merged
merged 1 commit into from
May 28, 2023

Conversation

tyconsulting
Copy link
Contributor

@tyconsulting tyconsulting commented May 25, 2023

Description

add AppInsights Diagnostic Settings. Diagnostic settings for App Insights is supported for the new Workspace-based AppInsights (which is the only flavour that the CARML module supports).

Pipeline references

Insights - Components

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@tyconsulting tyconsulting marked this pull request as ready for review May 25, 2023 07:49
@tyconsulting tyconsulting requested a review from a team as a code owner May 25, 2023 07:49
@eriqua eriqua changed the title add AppInsights Diagnostic Settings [Modules] Add AppInsights Diagnostic Settings May 25, 2023
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels May 25, 2023
@ahmadabdalla ahmadabdalla merged commit c0acca1 into Azure:main May 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants