Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Test Files & ReadMe function to compensate for change (1/2) #3283

Merged
merged 3 commits into from
Jun 4, 2023
Merged

[Modules] Updated Test Files & ReadMe function to compensate for change (1/2) #3283

merged 3 commits into from
Jun 4, 2023
+2,148 −1,184

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented May 28, 2023 •
edited by eriqua

Description

This is the first of 2 PRs for the alignment of the PBR test files.

  • Updated Test Files to leverage new namePrefix parameter
  • Updated ReadMe function to compensate for change (as it would otherwise change all readmes's without a proper contingency)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
MachineLearningServices - Workspaces
ContainerInstance - ContainerGroups
Insights - Components

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] testing category: testing [cat] utilities category: utilities [cat] modules category: modules labels May 28, 2023
@AlexanderSehr AlexanderSehr linked an issue May 28, 2023 that may be closed by this pull request
[PBR alignment] [Modules] Add main.test.bicep in root of .tests folder to invoke CARML individual test cases #3255
Closed
@AlexanderSehr AlexanderSehr changed the title [Modules] Updated Test Files & ReadMe function to compensate for change [Modules] Updated Test Files & ReadMe function to compensate for change (1/2) May 28, 2023
@AlexanderSehr AlexanderSehr marked this pull request as ready for review May 28, 2023 16:20
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner May 28, 2023 16:20
@AlexanderSehr AlexanderSehr mentioned this pull request May 31, 2023
Merged
4 tasks
eriqua
eriqua approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit d202bd3 into main Jun 4, 2023
11 of 13 checks passed
@eriqua eriqua deleted the users/alsehr/3255_test_0 branch June 4, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [cat] utilities category: utilities enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PBR alignment] [Modules] Add main.test.bicep in root of .tests folder to invoke CARML individual test cases
2 participants
@AlexanderSehr @eriqua