-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] New Module - Relay Namespaces #3307
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @jeremytbrun :) Please see comments. Also please feel free to reach out for clarification.
modules/web/sites/slots/hybrid-connection-namespaces/relays/metadata.json
Outdated
Show resolved
Hide resolved
modules/web/sites/slots/hybrid-connection-namespaces/relays/metadata.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…tadata.json Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…tadata.json Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…s/README.md Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…s/metadata.json Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…s/main.bicep Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…s/metadata.json Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…in.bicep Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…in.bicep Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…un/ResourceModules into 3033-Add-Relay-Support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeremytbrun . Thanks for the updates. I've added some suggestions and comments after the recent changes. Please rerun the readme generator for both the Sites and the new relay namespace folders. Also could you please rerun the workflows in your branch so I can review once the updates have been made. Thank you again!
modules/web/sites/slots/hybrid-connection-namespaces/relays/main.bicep
Outdated
Show resolved
Hide resolved
modules/web/sites/slots/hybrid-connection-namespaces/relays/main.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…in.bicep Co-authored-by: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com>
…un/ResourceModules into 3033-Add-Relay-Support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!! Approved :)
@jeremytbrun I have approved the PR. Seems to be some branch conflicts outstanding. Can you please resolve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some conflicts that need to be ironed out. Sorry just noticed this
Description
Resolves #3303
Added support for creating Azure Relay Namespaces with Hybrid Connections or WCF Relays.
Added support to connect Azure Web and Function apps to Hybrid Connections.
Pipeline references
Type of Change
New feature (non-breaking change which adds functionality)
Checklist