Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Align input child parameter objects to resourceType casing #3313

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Jun 5, 2023

Description

  • Align casing of the input child parameter objects to the corresponding resourceType

    Example: eventhubs input object in the event-hub/namespace module must be eventhubs and not eventHubs since its corresponding resourceType is Microsoft.EventHub/namespaces/eventhubs.

    This is to allow the readme generator file to retrieve the link to the child module readme documentation and add that to the parent readme

  • Update readme files

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ApiManagement - Service (different issue)
Insights - Web Tests
EventHub - Namespaces
EventGrid - Topics
Insights - PrivateLinkScopes

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua marked this pull request as ready for review June 5, 2023 13:25
@eriqua eriqua requested a review from a team as a code owner June 5, 2023 13:25
@eriqua eriqua enabled auto-merge (squash) June 5, 2023 13:25
@eriqua eriqua merged commit 6cde5f5 into main Jun 5, 2023
19 of 22 checks passed
@eriqua eriqua deleted the users/erikag/readme-update branch June 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants