Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Update Event Grid Module - Fix typo, not checking on loop-item #3357

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

davidkarlsen
Copy link
Contributor

@davidkarlsen davidkarlsen commented Jun 22, 2023

Description

Thank you for your contribution !

Please include a summary of the change and which issue is fixed.

The code is not checking the property on the item being looped over

Please also include the context.

systemtopic subs

List any dependencies that are required for this change.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Signed-off-by: David J. M. Karlsen <david.johan.macdonald.karlsen@dnb.no>
@davidkarlsen davidkarlsen requested a review from a team as a code owner June 22, 2023 08:04
@ahmadabdalla
Copy link
Contributor

@davidkarlsen thank you for the fix! Have you reran the readme and redeployed the module for testing after the change?

@ahmadabdalla ahmadabdalla changed the title fix typo, not checking on loop-item [Modules] Update Event Grid Module - Fix typo, not checking on loop-item Jun 22, 2023
@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Jun 22, 2023
@davidkarlsen
Copy link
Contributor Author

@ahmadabdalla there are no changes in docs, the parameters are unchanged.
I have no infra/funds to run tests on - but as it was clearly not working as intended.

@ahmadabdalla
Copy link
Contributor

All good. Approved. Will check our CI upon merge

@ahmadabdalla ahmadabdalla merged commit 437cdc9 into Azure:main Jun 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants