Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Moved metadata to template & removed dedicated file #3426

Merged
merged 8 commits into from
Jul 30, 2023
Merged

[Modules] Moved metadata to template & removed dedicated file #3426

merged 8 commits into from
Jul 30, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jul 14, 2023 •
edited

Description

Since version 0.19.5 we can now implement the metadata in the main.bicep template itself

  • This Pull Request does just that.
  • It updates the Set-ModuleReadMe utility to account for the change
  • It updates the test cases to account for this change

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices - Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jul 14, 2023
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing [cat] utilities category: utilities labels Jul 14, 2023
@AlexanderSehr AlexanderSehr linked an issue Jul 14, 2023 that may be closed by this pull request
[Feature Request]: Move the metadata.json content to the template, update utilities & tests #3425
Closed
@AlexanderSehr AlexanderSehr marked this pull request as ready for review July 17, 2023 16:09
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 17, 2023 16:09
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 17, 2023 16:09
@AlexanderSehr AlexanderSehr mentioned this pull request Jul 18, 2023
Closed
@AlexanderSehr AlexanderSehr mentioned this pull request Jul 28, 2023
Closed
4 tasks
eriqua
eriqua reviewed Jul 30, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round review done

eriqua
eriqua approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 98570b3 into main Jul 30, 2023
7 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/3425_metadataUpdate branch July 30, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] testing category: testing [cat] utilities category: utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Move the metadata.json content to the template, update utilities & tests
2 participants
@AlexanderSehr @eriqua