Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added Private Endpoint support to Cosmos DB #3505

Merged
merged 7 commits into from
Aug 6, 2023
Merged

[Modules] Added Private Endpoint support to Cosmos DB #3505

merged 7 commits into from
Aug 6, 2023

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Added Private Endpoint support to Cosmos DB
  • Added test case in SQL DB template file

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DocumentDB - DatabaseAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 5, 2023 11:25
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 5, 2023
@AlexanderSehr AlexanderSehr linked an issue Aug 5, 2023 that may be closed by this pull request
[Feature Request]: Private endpoint support for Microsoft.DocumentDB/databaseAccounts #1800
Closed
eriqua
eriqua approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit fe9bead into main Aug 6, 2023
8 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1800_cosmosPE branch August 6, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Private endpoint support for Microsoft.DocumentDB/databaseAccounts
2 participants
@AlexanderSehr @eriqua