Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI environment] Retrieve main resource type leveraging api specs #3508

Merged
merged 20 commits into from
Aug 8, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Aug 5, 2023

Description

Closes #3475

Update set-module readme to retrieve main resource type from module folder path leveraging api specs json file
Works with both singular and plural module folder names, hence can be merged to main

Should be merged after #3507 #3510 #3512

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Storage - StorageAccounts
Compute - VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added documentation Improvements or additions to documentation [cat] modules category: modules [cat] testing category: testing labels Aug 5, 2023
@eriqua eriqua marked this pull request as ready for review August 6, 2023 10:05
@eriqua eriqua requested a review from a team as a code owner August 6, 2023 10:05
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@eriqua eriqua enabled auto-merge (squash) August 6, 2023 20:11
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@eriqua eriqua merged commit aa19c3e into main Aug 8, 2023
3 of 5 checks passed
@eriqua eriqua deleted the users/avm/readme_specs_title branch August 8, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update set-module readme to comply with singular form
2 participants