Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Convert module names to singular (MAIN) #3573

Merged
merged 13 commits into from
Aug 21, 2023
Merged

[Modules] Convert module names to singular (MAIN) #3573

merged 13 commits into from
Aug 21, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Aug 13, 2023 •
edited

Description

TODO: retest all pipelines after PR #3570 and #3571 are merged to dev branch -> DONE

TODO: remove utility scripts and jsonc used for conversion -> DONE

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AAD - DomainServices
AnalysisServices - Servers
ApiManagement - Service
App - ContainerApps
App - Managed Environments
AppConfiguration - ConfigurationStores
Authorization - Locks
Authorization - PolicyAssignments
Authorization - PolicyDefinitions
Authorization - PolicyExemptions
Authorization - PolicySetDefinitions
Authorization - RoleAssignments
Authorization - RoleDefinitions
Automation - AutomationAccounts
Batch - BatchAccounts
Cache - Redis
CDN - Profiles
CognitiveServices - Accounts
Compute - AvailabilitySets
Compute - DiskEncryptionSets
Compute - Disks
Compute - Galleries
Compute - Images
Compute - ProximityPlacementGroups
Compute - SshPublicKeys
Compute - VirtualMachines
Compute - VirtualMachineScaleSets
Consumption - Budgets
ContainerInstance - ContainerGroups
ContainerRegistry - Registries
ContainerService - ManagedClusters
Databricks - Workspaces
DataFactory - Factories
DataProtection - BackupVaults
DbForMySQL - FlexibleServers
DbForPostgreSQL - FlexibleServers
DesktopVirtualization - ApplicationGroups
DesktopVirtualization - HostPools
DesktopVirtualization - Scalingplans
DesktopVirtualization - Workspaces
DevTestLab - Labs
DigitalTwins - DigitalTwinsInstances
DocumentDB - DatabaseAccounts
EventGrid - Domains
EventGrid - System Topics
EventGrid - Topics
EventHub - Namespaces
HealthBot - HealthBots
HealthcareApis - Workspaces
Insights - ActionGroups
Insights - ActivityLogAlerts
Insights - Components
Insights - DataCollectionEndpoints
Insights - DataCollectionRules
Insights - DiagnosticSettings
Insights - MetricAlerts
Insights - PrivateLinkScopes
Insights - ScheduledQueryRules
Insights - Web Tests
KeyVault - Vaults
KubernetesConfiguration - Extensions
KubernetesConfiguration - FluxConfigurations
Logic - Workflows
MachineLearningServices - Workspaces
Maintenance - MaintenanceConfigurations
ManagedIdentity - UserAssignedIdentities
ManagedServices - RegistrationDefinitions
Management - ManagementGroups
NetApp - NetAppAccounts
Network - ApplicationGateways
Network - ApplicationGatewayWebApplicationFirewallPolicies
Network - ApplicationSecurityGroups
Network - AzureFirewalls
Network - BastionHosts
Network - Connections
Network - DdosProtectionPlans
Network - DNS Forwarding Rulesets
Network - DNS Resolvers
Network - ExpressRouteCircuits
Network - ExpressRouteGateways
Network - FirewallPolicies
Network - Frontdoors
Network - IpGroups
Network - LoadBalancers
Network - LocalNetworkGateways
Network - NatGateways
Network - Network Managers
Network - NetworkInterfaces
Network - NetworkSecurityGroups
Network - NetworkWatchers
Network - PrivateDnsZones
Network - PrivateEndpoints
Network - PrivateLinkServices
Network - Public DnsZones
Network - PublicIpAddresses
Network - PublicIpPrefixes
Network - RouteTables
Network - ServiceEndpointPolicies
Network - TrafficManagerProfiles
Network - VirtualHubs
Network - VirtualNetworkGateways
Network - VirtualNetworks
Network - VirtualWans
Network - VPN Sites
Network - VPNGateways
Network: ApplicationGatewayWebApplicationFirewallPolicies
OperationalInsights - Workspaces
OperationsManagement - Solutions
PolicyInsights - Remediations
PowerBiDedicated - Capacities
Purview - Accounts
RecoveryServices - Vaults
Relay - Namespaces
Resources - DeploymentScripts
Resources - ResourceGroups
Resources - Tags
Security - AzureSecurityCenter
ServiceBus - Namespaces
ServiceFabric - Clusters
SignalRService - SignalR
SignalRService - WebPubSub
Sql - ManagedInstances
Sql - Servers
Storage - StorageAccounts
Synapse - PrivateLinkHubs
Synapse - Workspaces
VirtualMachineImages - ImageTemplates
Web - Connections
Web - HostingEnvironments
Web - Serverfarms
Web - Sites
Web - StaticSites

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

AlexanderSehr and others added 8 commits July 28, 2023 16:31
@AlexanderSehr
Added mapping table
757df4b
@AlexanderSehr
Update rtMapping.jsonc
5aa2c07
@eriqua
json update (#3472)
acb19dc
@eriqua
Merge branch 'main' into users/avm/3452_singularNames
101ebc7
@AlexanderSehr @eriqua
[Utilities] Updated utility references to new naming scheme (#3471)
8330705 
* Replaced first couple paths

* Updated tools folder

* Updated pipelines folder

* Update to latest

* Update utilities/pipelines/resourceDeployment/New-TemplateDeployment.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/pipelines/resourcePublish/Get-ModulesToPublish.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/pipelines/resourcePublish/Get-TemplateSpecsName.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/pipelines/resourcePublish/Get-TemplateSpecsName.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/tools/Update-RoleAssignmentList.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/tools/Update-RoleAssignmentList.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Update utilities/tools/Update-RoleAssignmentList.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

* Updated deployment name gen & examples

* Fixed name shortening

---------

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@eriqua
merge latest
c8160bc
@AlexanderSehr
[CI Environment] Update pipelines to new singular resource type names (…
92dcd20 
…#3455)

* Updated GH workflows

* Updated ADO pipelines

* Updated further paths
@eriqua
Merge branch 'main' into users/avm/3452_singularNames
f3fe986
@eriqua eriqua linked an issue Aug 13, 2023 that may be closed by this pull request
[Feature Request]: Implement singular folder names #3452
Closed
This was referenced Aug 14, 2023
Merged
Merged
Closed
Draft
@eriqua
[Modules] Convert folders and references to singular (DEV) (#3570)
d1617d6 
* first run

* second run

* third run

* 4th run

* convert missing folders

* update script

* vm cross

* update specs aligned

* tags

* event subscription

* mapping

* ref

* dig twins

* vpn

* web
@eriqua eriqua mentioned this pull request Aug 17, 2023
Closed
10 tasks
eriqua and others added 4 commits August 20, 2023 07:27
@eriqua
[Modules] Update readmes for singular module names (DEV) (#3571)
e3dbd27 
* first run

* second run

* third run

* 4th run

* readmes

* readmes fixed

* vm

* singular2

* singular readme2

* convert missing folders

* update script

* vm cross

* update specs aligned

* des readme manual fix

* tags

* event subscription

* mapping

* ref

* dig twins

* vpn

* web

* merge latest and regen readmes

* az fw

* data factory
@eriqua
Merge branch 'main' into users/avm/3452_singularNames
95a7be5
@eriqua
Merge branch 'users/avm/3452_singularNames' of https://github.com/Azu…
cab7c5d 
…re/ResourceModules into users/avm/3452_singularNames
@eriqua
cleanup utility
c7c9290
@eriqua eriqua mentioned this pull request Aug 20, 2023
Merged
10 tasks
@eriqua eriqua added [cat] pipelines category: pipelines [cat] modules category: modules [cat] testing category: testing [cat] github category: GitHub [cat] azure devops category: Azure DevOps [cat] utilities category: utilities labels Aug 20, 2023
@eriqua eriqua marked this pull request as ready for review August 20, 2023 19:39
@eriqua eriqua requested a review from a team as a code owner August 20, 2023 19:39
@eriqua eriqua enabled auto-merge (squash) August 20, 2023 19:47
@eriqua eriqua merged commit c69db01 into main Aug 21, 2023
3 of 8 checks passed
@eriqua eriqua deleted the users/avm/3452_singularNames branch August 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@eriqua eriqua

Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] testing category: testing [cat] utilities category: utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Implement singular folder names
2 participants
@eriqua @AlexanderSehr