-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Fix/Add purge during removal of machine learning workspace #3597
Merged
AlexanderSehr
merged 27 commits into
Azure:main
from
MariusStorhaug:feat/purgeMachineLearningWorkspace
Sep 4, 2023
Merged
[Modules] Fix/Add purge during removal of machine learning workspace #3597
AlexanderSehr
merged 27 commits into
Azure:main
from
MariusStorhaug:feat/purgeMachineLearningWorkspace
Sep 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusStorhaug
changed the title
[Modules] Add purge during removal of machine learning workspace
[Modules] Fix/Add purge during removal of machine learning workspace
Aug 20, 2023
MariusStorhaug
force-pushed
the
feat/purgeMachineLearningWorkspace
branch
from
August 20, 2023 19:14
4436e37
to
fd73e7c
Compare
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourcePostRemoval.ps1
Outdated
Show resolved
Hide resolved
MariusStorhaug
commented
Aug 21, 2023
utilities/pipelines/resourceRemoval/helper/Remove-ResourceList.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
The temp commit is to fix the privateEndpoint API version issues. This is just to show the functionality of the removal script changes and will be reverted as it is part of #3585. |
MariusStorhaug
force-pushed
the
feat/purgeMachineLearningWorkspace
branch
from
August 21, 2023 19:38
febb9e5
to
6ea01aa
Compare
MariusStorhaug
force-pushed
the
feat/purgeMachineLearningWorkspace
branch
from
August 21, 2023 22:04
f55d543
to
91c3f53
Compare
AlexanderSehr
added
enhancement
New feature or request
[cat] pipelines
category: pipelines
[cat] utilities
category: utilities
labels
Aug 22, 2023
utilities/pipelines/resourceRemoval/helper/Remove-ResourceList.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
…val.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…val.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…val.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…val.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceRemoval.ps1
Outdated
Show resolved
Hide resolved
AlexanderSehr
previously approved these changes
Sep 4, 2023
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceLockRemoval.ps1
Outdated
Show resolved
Hide resolved
…Removal.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
utilities/pipelines/resourceRemoval/helper/Invoke-ResourceLockRemoval.ps1
Outdated
Show resolved
Hide resolved
…Removal.ps1 Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
approved these changes
Sep 4, 2023
Pipelines are not green, but failing for other reasons. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[cat] pipelines
category: pipelines
[cat] utilities
category: utilities
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3596
Description
Invoke-ResourceLockRemoval
.Before log:
This PR
Reran a deployment, where I went in to add some 'rogue' locks, result is as follows:
Can be seen on the pipeline linked below on the enc tests.
Pipeline references
Type of Change
Checklist