Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PSRule] Fix Rule Azure.Policy.AssignmentAssignedBy #2667 #3719

Merged
merged 4 commits into from
Aug 26, 2023
Merged

[PSRule] Fix Rule Azure.Policy.AssignmentAssignedBy #2667 #3719

merged 4 commits into from
Aug 26, 2023

Conversation

elanzel
Copy link
Contributor

@elanzel elanzel commented Aug 25, 2023

Description

Policy assignment test updates for PSRule requirements:

  • Add assignedby metadata on existing metadata blocks
  • Setname, description and metablock with assigned identity in min files

closes #2667

Pipeline references

Pipeline
Authorization - PolicyAssignments

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@elanzel elanzel added enhancement New feature or request [cat] modules category: modules labels Aug 25, 2023
@elanzel elanzel requested a review from a team as a code owner August 25, 2023 18:26
@elanzel elanzel self-assigned this Aug 25, 2023
@AlexanderSehr AlexanderSehr merged commit cf6f446 into main Aug 26, 2023
23 of 24 checks passed
@AlexanderSehr AlexanderSehr deleted the users/elanzel/2667-psrule-fix-rule-policyassignement branch August 26, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@elanzel elanzel

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
Azure Verified Modules (AVM) - Module...
Development

Successfully merging this pull request may close these issues.

[PSRule] Fix Rule Azure.Policy.AssignmentAssignedBy
3 participants
@elanzel @ahmadabdalla @AlexanderSehr