Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Update deployment search to not prematurely throw an exception #3871

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 29, 2023

Description

  • Updated deployment search to not prematurely throw an exception if a deployment name does not yield deployed resources
  • Currently, the logic searches the deployment name until the timeout is reached and throws an exception if no deployments are found (which is an issue if runnning, for example, retries)
  • Instead it should then continue with the next name and only throw an exception if no deployment is found after checking all names

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network - NetworkInterfaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 29, 2023 09:50
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] pipelines category: pipelines labels Aug 29, 2023
@AlexanderSehr AlexanderSehr added this to the Release v0.11.0 milestone Aug 29, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 29, 2023 09:51
@AlexanderSehr AlexanderSehr merged commit e4b270c into main Aug 29, 2023
14 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/adjustDeplSearchLogic branch August 29, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants