Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Align GH removal with ADO #3890

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Sep 1, 2023

Fixes #3590
Replaces: #3591

Description

Aligning GH resource removal condition with ADO.

Pipeline references

Pipeline Expected behavior Actual result
Regular deploy Success
Deploy with failure Fail deployment, resources removed
Deploy with cancel Deploy some resources, cancel whole workflow

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug changed the title Align GH removal with ADO [Fixes] Align GH removal with ADO Sep 1, 2023
@MariusStorhaug MariusStorhaug marked this pull request as ready for review September 1, 2023 18:33
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner September 1, 2023 18:33
@AlexanderSehr AlexanderSehr merged commit 0bee488 into Azure:main Sep 1, 2023
1 check passed
@MariusStorhaug MariusStorhaug deleted the fix/GHremoval branch September 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Align ADO and GH removal of validation deployments
2 participants