Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated ACR common test case to support Paired region dependencies and updated to latest API version #3900

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Sep 1, 2023

Description

Currently ACR has hard coded paired region to northeurope. This fails the module when default test region is not westeurope.

Leveraged our existing implementation from MySQl where we fetch the paired region name dynamically using deployment scripts.

++ Updated API version to 2023-06-01-preview

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerRegistry - Registries

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Sep 1, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.11.0 milestone Sep 1, 2023
@ahmadabdalla ahmadabdalla self-assigned this Sep 1, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review September 1, 2023 21:16
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner September 1, 2023 21:16
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) September 1, 2023 21:16
@ahmadabdalla ahmadabdalla changed the title [Modules] Updated ACR common test case to support Paired region dependencies [Modules] Updated ACR common test case to support Paired region dependencies and updated to latest API version Sep 4, 2023
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@ahmadabdalla ahmadabdalla merged commit 40ba5e2 into main Sep 4, 2023
8 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/acrGeoUpdate branch September 4, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants