Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added new bicep features to tests #3902

Merged
merged 10 commits into from
Sep 5, 2023
Merged

[Modules] Added new bicep features to tests #3902

merged 10 commits into from
Sep 5, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 2, 2023 •
edited

Description

  • Introduced a special azure tag that becomes visible on the Azure Resource for reference
  • Introduced CIDR function to be used for subnet generation

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AAD - DomainServices
AnalysisServices - Servers
ApiManagement - Service
App - ContainerApps
App - Managed Environments
AppConfiguration - ConfigurationStores
Authorization - Locks
Authorization - PolicyAssignments
Authorization - PolicyDefinitions
Authorization - PolicyExemptions
Authorization - PolicySetDefinitions
Authorization - RoleAssignments
Authorization - RoleDefinitions
Automation - AutomationAccounts
Batch - BatchAccounts
Cache - Redis
CDN - Profiles
CognitiveServices - Accounts
Compute - AvailabilitySets
Compute - DiskEncryptionSets
Compute - Disks
Compute - Galleries
Compute - Images
Compute - ProximityPlacementGroups
Compute - SshPublicKeys
Compute - VirtualMachines
Compute - VirtualMachineScaleSets
Consumption - Budgets
ContainerInstance - ContainerGroups
ContainerRegistry - Registries
ContainerService - ManagedClusters
Databricks - Workspaces
DataFactory - Factories
DataProtection - BackupVaults
DbForMySQL - FlexibleServers
DbForPostgreSQL - FlexibleServers
DesktopVirtualization - ApplicationGroups
DesktopVirtualization - HostPools
DesktopVirtualization - Scalingplans
DesktopVirtualization - Workspaces
DevTestLab - Labs
DigitalTwins - DigitalTwinsInstances
DocumentDB - DatabaseAccounts
EventGrid - Domains
EventGrid - System Topics
EventGrid - Topics
EventHub - Namespaces
HealthBot - HealthBots
HealthcareApis - Workspaces
Insights - ActionGroups
Insights - ActivityLogAlerts
Insights - Components
Insights - DataCollectionEndpoints
Insights - DataCollectionRules
Insights - DiagnosticSettings
Insights - MetricAlerts
Insights - PrivateLinkScopes
Insights - ScheduledQueryRules
Insights - Web Tests
KeyVault - Vaults
KubernetesConfiguration - Extensions
KubernetesConfiguration - FluxConfigurations
Logic - Workflows
MachineLearningServices - Workspaces
Maintenance - MaintenanceConfigurations
ManagedIdentity - UserAssignedIdentities
ManagedServices - RegistrationDefinitions
Management - ManagementGroups
NetApp - NetAppAccounts
Network - ApplicationGateways
Network - ApplicationSecurityGroups
Network - AzureFirewalls
Network - BastionHosts
Network - Connections
Network - DdosProtectionPlans
Network - DNS Forwarding Rulesets
Network - DNS Resolvers
Network - ExpressRouteCircuits
Network - ExpressRouteGateways
Network - FirewallPolicies
Network - Frontdoors
Network - FrontDoorWebApplicationFirewallPolicies
Network - IpGroups
Network - LoadBalancers
Network - LocalNetworkGateways
Network - NatGateways
Network - Network Managers
Network - NetworkInterfaces
Network - NetworkSecurityGroups
Network - NetworkWatchers
Network - PrivateDnsZones
Network - PrivateEndpoints
Network - PrivateLinkServices
Network - Public DnsZones
Network - PublicIpAddresses
Network - PublicIpPrefixes
Network - RouteTables
Network - ServiceEndpointPolicies
Network - TrafficManagerProfiles
Network - VirtualHubs
Network - VirtualNetworkGateways
Network - VirtualNetworks
Network - VirtualWans
Network - VPN Sites
Network - VPNGateways
OperationalInsights - Workspaces
OperationsManagement - Solutions
PolicyInsights - Remediations
PowerBiDedicated - Capacities
Purview - Accounts
RecoveryServices - Vaults
Relay - Namespaces
ResourceGraph - Queries
Resources - DeploymentScripts
Resources - ResourceGroups
Resources - Tags
Security - AzureSecurityCenter
ServiceBus - Namespaces
ServiceFabric - Clusters
SignalRService - SignalR
SignalRService - WebPubSub
Sql - ManagedInstances
Sql - Servers
Storage - StorageAccounts
Synapse - PrivateLinkHubs
Synapse - Workspaces
VirtualMachineImages - ImageTemplates
Web - Connections
Web - HostingEnvironments
Web - Serverfarms
Web - Sites
Web - StaticSites

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 2, 2023
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Sep 2, 2023
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 2, 2023 16:21
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 2, 2023 16:21
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 2, 2023 16:21
@AlexanderSehr AlexanderSehr removed the [cat] modules category: modules label Sep 2, 2023
@AlexanderSehr AlexanderSehr changed the title Users/alsehr/new bicep features [Modules] Added new bicep features to tests Sep 3, 2023
@ahmadabdalla
Copy link
Contributor

@AlexanderSehr I've reviewed this and OK with it. Did you want to validate README's before we merge given recent updates on modules?

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr I've reviewed this and OK with it. Did you want to validate README's before we merge given recent updates on modules?

Hey Ahmad, which recent updates? There seem to be no conflicts, but I can regenerate the docs again based on latest main just in case

@AlexanderSehr
Copy link
Contributor Author

@AlexanderSehr I've reviewed this and OK with it. Did you want to validate README's before we merge given recent updates on modules?

Hey Ahmad, which recent updates? There seem to be no conflicts, but I can regenerate the docs again based on latest main just in case

Done, no changes

@AlexanderSehr AlexanderSehr merged commit b0221d8 into main Sep 5, 2023
4 of 5 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/newBicepFeatures branch September 5, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadabdalla ahmadabdalla ahmadabdalla approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] testing category: testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderSehr @ahmadabdalla