Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Platform] Enabled module publishing from feature branch prerelease publishing without publishing stable version #3906

Merged
merged 6 commits into from
Sep 5, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Sep 4, 2023

Description

Allowed filtering for the modules to be published to only include prerelease version if the feature branch is not Main/Master.

What was happening is that if I want to deploy the module pipeline for the first time and I am on a feature branch, if I attempt to publish into TS/BR/AzArtifacts, then it will publish stable versions along side the preview version. This should not happen as the branch is not main.

Also updated the set readme where [1] split filter was causing issues in the customer environment. Made it [-1] to align with other split filters in the script, as we always want to take the last element from the filter.

Finally, added warning if the profile is not loaded. This scenario happens when self-hosted agents are used, and causes random profile load failures.

Pipeline references

Pipeline
ManagedIdentity - UserAssignedIdentities

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Screenshots from ADO and GH for scenarios on feature branch and on main

Feature Branch

image

image

image

GitHub Actions

image

Azure DevOps

image

Main Branch

image

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla marked this pull request as ready for review September 4, 2023 23:10
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner September 4, 2023 23:10
@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] publishing category: publishing [cat] github category: GitHub [cat] azure devops category: Azure DevOps labels Sep 4, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.11.0 milestone Sep 4, 2023
@ahmadabdalla ahmadabdalla marked this pull request as draft September 5, 2023 06:02
@ahmadabdalla ahmadabdalla marked this pull request as ready for review September 5, 2023 06:23
@ahmadabdalla ahmadabdalla merged commit 096f450 into main Sep 5, 2023
4 of 6 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/hotFixes branch September 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] publishing category: publishing
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Publishing a new module from a feature branch with prerelease will create other stable releases
2 participants