Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] ML - Wait on Private Endpoints before creating compute instances #3908

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[Modules] ML - Wait on Private Endpoints before creating compute instances #3908

merged 2 commits into from
Sep 4, 2023

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 4, 2023 •
edited

Description

Based on PR #3715
cc: @Sdelausnay

When you deploy the ML Studio in a private environment and want to also create compute instances, there is a changes that the compute instances can't connect to the MLS due the the fact that the Private Endpoints of MLS have not been created. So making sure to only start the creation of compute instance once the Private Endpoints of MLS have been created.

When running the test scripts, the Private Endpoint test failed because of an old API version, so have also updated.

Pipeline references

Pipeline
MachineLearningServices - Workspaces

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@Sdelausnay @AlexanderSehr
[Modules] ML - Wait on Private Endpoints before creating compute inst…
95e677a 
…ances (#3715)

* wait on PeP before creating compute

* fix private end-point

* reset pep

* change pep

* update version

* update readme

* fix json

* fix json

* update mls json

* update documents

* reset settings

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 4, 2023 14:12
@AlexanderSehr AlexanderSehr self-assigned this Sep 4, 2023
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Sep 4, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 4, 2023 14:14
@AlexanderSehr AlexanderSehr changed the title [Modules] ML - Wait on Private Endpoints before creating compute inst… [Modules] ML - Wait on Private Endpoints before creating compute instances Sep 4, 2023
@AlexanderSehr AlexanderSehr mentioned this pull request Sep 4, 2023
Merged
10 tasks
@AlexanderSehr AlexanderSehr merged commit 805e4e0 into main Sep 4, 2023
16 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/Sdelausnay_followUp branch September 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderSehr @Sdelausnay