Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Updated Cosmos DB Module tests to support dynamic primary and secondary region locations #3946

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Sep 8, 2023

Description

Updated Cosmos DB to support dynamic location for primary and secondary regions in test file. Used the deployment script pattern we applied for other modules.

Pipeline
DocumentDB - DatabaseAccounts

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Sep 8, 2023
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner September 8, 2023 21:21
@ahmadabdalla ahmadabdalla self-assigned this Sep 8, 2023
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) September 8, 2023 21:23
@ahmadabdalla ahmadabdalla merged commit 9bd1b46 into main Sep 9, 2023
20 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/cosmosUpdate branch September 9, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants