-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] Support for inGuest Patch support with Azure Update Manager #3956
Conversation
installPatches support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 2 asks though:
- Please also update the readme using our Set-ModuleReadme utility
- If possible, it would also be great if we could add the usage of the parameter to the common test case (which would also need a subsequent update of the Readme). This helps us to make sure the change works and further is a good reference for the community on how the object must look like
Added missing module README.md and modified common test case. Can you have a look please ? Another common question: How can I assign the follwong labels to PR:
|
You don't, but I just did. Will review shortly :) |
modules/maintenance/maintenance-configuration/.test/common/main.test.bicep
Outdated
Show resolved
Hide resolved
Looks great. Just 1 comment, then we can merge. Thanks @jdrepo |
Here we go. Thanks @jdrepo |
Thanks. |
Description
Based on #3954
Support for the "installPatches" property in the Microsoft.Maintenance/maintenanceConfigurations resource
Pipeline references
Type of Change
Checklist