Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Support for inGuest Patch support with Azure Update Manager #3956

Merged
merged 13 commits into from
Sep 13, 2023

Conversation

jdrepo
Copy link
Contributor

@jdrepo jdrepo commented Sep 12, 2023

Description

Based on #3954

Support for the "installPatches" property in the Microsoft.Maintenance/maintenanceConfigurations resource

Pipeline references

Pipeline
Maintenance - MaintenanceConfigurations

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@jdrepo jdrepo requested a review from a team as a code owner September 12, 2023 15:52
@jdrepo jdrepo changed the title Release/installPatches [Modules] Release/installPatches Sep 12, 2023
@jdrepo jdrepo changed the title [Modules] Release/installPatches [Modules] Support for in Guest Patch support with Azure Update Manager Sep 12, 2023
@jdrepo jdrepo changed the title [Modules] Support for in Guest Patch support with Azure Update Manager [Modules] Support for inGuest Patch support with Azure Update Manager Sep 12, 2023
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 2 asks though:

  • Please also update the readme using our Set-ModuleReadme utility
  • If possible, it would also be great if we could add the usage of the parameter to the common test case (which would also need a subsequent update of the Readme). This helps us to make sure the change works and further is a good reference for the community on how the object must look like

@jdrepo
Copy link
Contributor Author

jdrepo commented Sep 12, 2023

Added missing module README.md and modified common test case. Can you have a look please ?

Another common question: How can I assign the follwong labels to PR:

  • [cat] modules
  • enhancement

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Sep 12, 2023
@AlexanderSehr
Copy link
Contributor

Added missing module README.md and modified common test case. Can you have a look please ?

Another common question: How can I assign the follwong labels to PR:

  • [cat] modules
  • enhancement

You don't, but I just did. Will review shortly :)

@AlexanderSehr
Copy link
Contributor

Looks great. Just 1 comment, then we can merge. Thanks @jdrepo

@AlexanderSehr
Copy link
Contributor

Here we go. Thanks @jdrepo

@AlexanderSehr AlexanderSehr merged commit 194cab2 into Azure:main Sep 13, 2023
1 check passed
@jdrepo
Copy link
Contributor Author

jdrepo commented Sep 13, 2023

Thanks.
What will happen to the referenced issue #3954 in the Product backlog ?
Will it be closed automatically or should I close it by myself ?

@jdrepo jdrepo deleted the release/installPatches branch September 13, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support for in Guest Patch support with Azure Update Manager
2 participants