Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added module for Redis Cache Enterprise and Database #3984

Merged
merged 19 commits into from
Sep 17, 2023
Merged

[Modules] Added module for Redis Cache Enterprise and Database #3984

merged 19 commits into from
Sep 17, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Sep 16, 2023 •
edited

Description

Created a new module for Redis Cache Enterprise and Database child resource.
Added 3 test cases to validate parameter combinations:

  • Common: Deploys a Cluster with Private endpoints and cache persistence
  • Min: Minimum requirements.
  • Geo Replication: To support an enterprise cluster with Geo replication scenarios.

Common

image

Min

image

Geo replication

image

Pipeline references

image
image
image
image

Pipeline
New released Pipeline, tested via Azure DevOps

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Sep 16, 2023
@ahmadabdalla ahmadabdalla self-assigned this Sep 16, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review September 16, 2023 11:52
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner September 16, 2023 11:52
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) September 16, 2023 11:52
@ahmadabdalla ahmadabdalla merged commit 81c68b8 into main Sep 17, 2023
8 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/redisE branch September 17, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmadabdalla @AlexanderSehr