Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADO pipelines for validate, deploy, remove & publish #476

Merged
merged 123 commits into from
Dec 13, 2021
Merged

Create ADO pipelines for validate, deploy, remove & publish #476

merged 123 commits into from
Dec 13, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 15, 2021

Change

  • Created Azure DevOps pipelines for validate, deploy, remove & publish

  • Renamed GitHub variables file to global.variables.json to align with the Azure DevOps variable file (which has a better name - global.variables.yml)

  • Overhauled documentation

    • Added Azure DevOps sections where appropriate
    • Fixed incorrect wiki content (e.g. outdated environment variables, links, etc.)
    • Restructured the location of information a bit
  • Tested:

    • Repo in GitHub, executing in Azure DevOps
    • Analysis Services, vWAN & Virtual Machines
    • Azure DevOps Artifacts
    • Multi Repo approach
  • Out of scope

    • Platform pipelines (e.g. readMe update). Those can be added in a later PR

Notes:

  • Leverages Azure DevOps Library Group for the same secrets as GitHub (e.g. subscription Id)
  • The Azure DevOps triggers that use wildcards do currently not work. This feature was rolled out, and then rolled back and is lacking any update ever since. The only alternative are 'full-file-paths' which is not really an alternative at all. I'd keep it as is until the feature starts working again

Pipeline reference

See IaCS Pipelines in folder 'CARML-Modules'

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr self-assigned this Nov 15, 2021
@AlexanderSehr AlexanderSehr changed the title Recovered original state + moved token replacement Create ADO pipelines for validate, deploy, remove & publish Nov 15, 2021
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [cat] testing category: testing [prio] medium importance of the issue: medium priority enhancement New feature or request labels Nov 15, 2021
@AlexanderSehr AlexanderSehr added this to the v 0.3 milestone Nov 15, 2021
@AlexanderSehr AlexanderSehr marked this pull request as draft November 17, 2021 11:29
@MariusStorhaug
Copy link
Contributor

I am in the progress of reviewing. Its just a big PR...

@MariusStorhaug
Copy link
Contributor

Based on the file name change, should we not replace the following:

- variableFileName: 'variables.module'
+ variableFileName: 'global.variables'

@MariusStorhaug
Copy link
Contributor

Need to have a look at how we allow the action to also work with ARM/json template files.

@MariusStorhaug
Copy link
Contributor

What about child resources? They are not nested templates when converted to json. Should we also remove/clean up the folders representing the child resources?

Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments are fixed. Approved.

@AlexanderSehr AlexanderSehr merged commit c7eb52d into Azure:main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [cat] testing category: testing enhancement New feature or request [prio] medium importance of the issue: medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Pipeline Implementation ADO
4 participants