Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depedency pipeline cleanup #699

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Depedency pipeline cleanup #699

merged 4 commits into from
Dec 1, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 1, 2021 •
edited

Change

  • Removed redundant reference in dependency pipeline (moduleName) as it is not leveraged in the referenced composite action
  • Added some whitespaces to policyDefinitions
  • Fixed virtual machine dependency parameters

Pipeline reference
.Platform: Dependencies

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Dec 1, 2021
@AlexanderSehr AlexanderSehr added [cat] testing category: testing bug Something isn't working labels Dec 1, 2021
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Dec 1, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 1, 2021 that may be closed by this pull request
Remove moduleName from dependency pipeline deploy jobs #697
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 1, 2021 13:19
eriqua
eriqua approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 2d2eef7 into main Dec 1, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/697_dependenciesCleanup branch December 1, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] testing category: testing
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Remove moduleName from dependency pipeline deploy jobs
2 participants
@AlexanderSehr @eriqua