Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RBAC to secret & key child modules #706

Merged
merged 10 commits into from
Dec 4, 2021
Merged

Added RBAC to secret & key child modules #706

merged 10 commits into from
Dec 4, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 2, 2021 •
edited

Change

  • Added RBAC to secret & key child modules
  • Added access policies child module to allow dedicated deployment
  • Added & updated documentation

Pipeline reference
KeyVault: Vaults

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr linked an issue Dec 2, 2021 that may be closed by this pull request
Add secret/key level RBAC to key vault module #702
Closed
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Dec 2, 2021
@AlexanderSehr AlexanderSehr self-assigned this Dec 2, 2021
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 2, 2021 11:41
@AlexanderSehr AlexanderSehr changed the title Users/alsehr/702 kv rbac Added RBAC to secret & key child modules Dec 2, 2021
eriqua
eriqua approved these changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 8e5ed44 into main Dec 4, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/702_kv_rbac branch December 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add secret/key level RBAC to key vault module
2 participants
@AlexanderSehr @eriqua