Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules Design update #769

Merged
merged 8 commits into from
Dec 9, 2021
Merged

Modules Design update #769

merged 8 commits into from
Dec 9, 2021

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Dec 8, 2021

Change

Adding bicep modules section and deployment names subsection
Minor adjustments

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added this to the v 0.4 milestone Dec 8, 2021
@eriqua eriqua self-assigned this Dec 8, 2021
@eriqua eriqua enabled auto-merge (squash) December 8, 2021 19:57
eriqua and others added 5 commits December 8, 2021 21:51
@eriqua @AlexanderSehr
Update docs/wiki/ModulesDesign.md
f04ea95 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@eriqua @AlexanderSehr
Update docs/wiki/ModulesDesign.md
8335d0c 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
note on scope
93bfa72
replaced provider
36db836
rbac update
5939ae1
@AlexanderSehr AlexanderSehr added the documentation Improvements or additions to documentation label Dec 9, 2021
@eriqua eriqua merged commit 2c7a3d7 into main Dec 9, 2021
@AlexanderSehr AlexanderSehr deleted the users/erikag/depname-wiki branch December 9, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@eriqua eriqua

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eriqua @AlexanderSehr @MariusStorhaug