Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests and documentation for conversion script #821

Merged
merged 78 commits into from
Dec 22, 2021
Merged

Adding tests and documentation for conversion script #821

merged 78 commits into from
Dec 22, 2021

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Dec 17, 2021 •
edited

Change

Adding Pester tests and documentation for the Bicep->ARM conversion script

.Platform: run pester test for convert to ARM template script

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan marked this pull request as draft December 17, 2021 13:21
@AlexanderSehr AlexanderSehr added [cat] testing category: testing documentation Improvements or additions to documentation labels Dec 18, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 18, 2021 that may be closed by this pull request
Test and documentation of conversion script (Bicep -> ARM) #751
Closed
rahalan and others added 4 commits December 21, 2021 16:51
@rahalan @AlexanderSehr
Update docs/wiki/ConversionScript.md
6efd40a 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/ConversionScript.md
4f86b05 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/ConversionScript.md
fb625bd 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/ConversionScript.md
c40356d 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr and others added 3 commits December 22, 2021 08:46
@AlexanderSehr
Simplified pipeline, simplified tests, extended Logic to ADO, fixed c…
eb1f159 
…onversion bug (#835)

* Added initial script

* Update to latest

* Optimized files

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Path & Match fixes

* Updated tests

* Update to latest

* Minor change

* Extended replacement

* Extended replacement

* Updated trigger

* Update to latest
@rahalan
update wiki
f49887c
@rahalan
update wiki
4d6f470
@rahalan rahalan enabled auto-merge (squash) December 22, 2021 09:02
@rahalan @AlexanderSehr
Update docs/wiki/UtilitiesConversionScript.md
24a23a4 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/UtilitiesConversionScript.md
4bbc7b5 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
rahalan and others added 3 commits December 22, 2021 10:51
@rahalan @AlexanderSehr
Update docs/wiki/UtilitiesConversionScript.md
d4e4423 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/UtilitiesConversionScript.md
55a151b 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan @AlexanderSehr
Update docs/wiki/UtilitiesConversionScript.md
4f363d2 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@rahalan rahalan merged commit 266c153 into main Dec 22, 2021
@AlexanderSehr AlexanderSehr deleted the users/rahalan/TestConversionScript branch December 22, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@MariusStorhaug MariusStorhaug Awaiting requested review from MariusStorhaug

Assignees

@rahalan rahalan

Labels
[cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Test and documentation of conversion script (Bicep -> ARM)
3 participants
@rahalan @AlexanderSehr @eriqua