Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PrivateDnsZone removal #824

Merged
merged 10 commits into from
Dec 20, 2021
Merged

Fixing PrivateDnsZone removal #824

merged 10 commits into from
Dec 20, 2021

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Dec 20, 2021

Change

Closes issue #823

  • Changing default vnetlink name from <vnetname> to <vnetname>-vnetlink otherwise filtered out from the removal job since having the same name of a dependecy resource
  • Updating API to latest
  • Improving removal scripts verbosity

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working enhancement New feature or request [cat] modules category: modules labels Dec 20, 2021
@eriqua eriqua self-assigned this Dec 20, 2021
@eriqua eriqua merged commit bcb9f9f into main Dec 20, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 20, 2021 that may be closed by this pull request
@AlexanderSehr AlexanderSehr deleted the users/erikag/privdns branch December 22, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrivateDnsZone removal Bug Report
2 participants