Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Log analytics workspace removal #841

Merged
merged 10 commits into from
Dec 23, 2021
Merged

Fix Log analytics workspace removal #841

merged 10 commits into from
Dec 23, 2021

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Dec 23, 2021

Change

  • Adding custom removal order
  • Adding post deletion (needs to recover soft deleted resource first)
  • Minor fix to output description

OperationalInsights: Workspaces

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added bug Something isn't working [cat] modules category: modules [cat] testing category: testing labels Dec 23, 2021
@eriqua eriqua added this to the v 0.4 milestone Dec 23, 2021
@eriqua eriqua self-assigned this Dec 23, 2021
@github-actions
Copy link

github-actions bot commented Dec 23, 2021

Unit Test Results

    1 files  ±    0    1 suites  ±0   59s ⏱️ - 1m 49s
  13 tests  -   22  13 ✔️  - 22      0 💤 ±    0  0 ±0 
165 runs   - 322  13 ✔️  - 22  152 💤  - 300  0 ±0 

Results for commit 5be3976. ± Comparison against base commit 89de262.

This pull request removes 35 and adds 13 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apiVersionSets] used resource type [service/apiVersionSets] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis/policies] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/authorizationServers] used resource type [service/authorizationServers] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/backends] used resource type [service/backends] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/caches] used resource type [service/caches] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/identityProviders] used resource type [service/identityProviders] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/namedValues] used resource type [service/namedValues] should use on of the recent API version(s). Currently using [2020-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/policies] used resource type [service/policies] should use on of the recent API version(s). Currently using [2020-06-01-preview]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces/dataSources] used resource type [workspaces/dataSources] should use on of the recent API version(s). Currently using [2020-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces/linkedServices] used resource type [workspaces/linkedServices] should use on of the recent API version(s). Currently using [2020-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces/savedSearches] used resource type [workspaces/savedSearches] should use on of the recent API version(s). Currently using [2020-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces/storageInsightConfigs] used resource type [workspaces/storageInsightConfigs] should use on of the recent API version(s). Currently using [2020-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [solutions] should use on of the recent API version(s). Currently using [2015-11-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [workspaces/dataSources] should use on of the recent API version(s). Currently using [2020-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.OperationalInsights/workspaces] used resource type [workspaces/linkedServices] should use on of the recent API version(s). Currently using [2020-08-01]
…

♻️ This comment has been updated with latest results.

…Removal.ps1

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@eriqua eriqua merged commit 1633dcd into main Dec 23, 2021
@AlexanderSehr AlexanderSehr deleted the users/erikag/law-update branch December 23, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules [cat] testing category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants