Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadBalancer: Added child resources + test cases #848

Merged
merged 10 commits into from
Jan 3, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 26, 2021

Change

  • Added resources
    • Inbound & Outboud Rules
  • Added backendAddressPool child-resource template
  • Refactored mandatory parameters
  • Fixed incorrect automated PowerShell casting in removal script (by enforcing type array). Without it, an array such as @( @{ name = 'abc'; type = 'cde'} ) is autoconverted to @{ name = 'abc'; type = 'cde'} an even though the item count should be 1, it is instead detected as 2

Pipeline reference
Network: LoadBalancers

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Dec 26, 2021
@AlexanderSehr AlexanderSehr self-assigned this Dec 26, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 26, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 26, 2021

Unit Test Results

    1 files  1 suites   45s ⏱️
    8 tests 8 ✔️   0 💤 0
100 runs  8 ✔️ 92 💤 0

Results for commit cdcf443.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 26, 2021 16:35
@AlexanderSehr AlexanderSehr merged commit 48d728d into main Jan 3, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/838_lb branch January 3, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules [cat] testing category: testing enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Inbound & Outbound NAT rules to LoadBalancer module
2 participants