Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing removal condition to avoid uncancelable pipeline #854

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 3, 2022

Change

There was a condition for the ADO deployment pipeline template missing that essentially made it impossible to stop the removal step.

Tested both the cancellation as well as end2end execution in IaCS.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Jan 3, 2022
@AlexanderSehr AlexanderSehr added [cat] azure devops category: Azure DevOps [cat] pipelines category: pipelines bug Something isn't working labels Jan 3, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 3, 2022 21:27
@AlexanderSehr AlexanderSehr merged commit f8302e9 into main Jan 4, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/adoconditionFix branch January 5, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] azure devops category: Azure DevOps [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants