Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Key vault with security recommendation #896

Merged
merged 18 commits into from
Jan 20, 2022
Merged

Update Key vault with security recommendation #896

merged 18 commits into from
Jan 20, 2022

Conversation

elbatane
Copy link
Contributor

@elbatane elbatane commented Jan 17, 2022 •
edited

Change

  • Updated parameters descriptions in main README:
    • networkAcls
    • privateEndpoints
    • diagnosticEventHubName.
    • diagnosticStorageAccountId
    • diagnosticWorkspaceId
  • Updated parameters.json: added example of networkAcls and privateEndpoints object values.
  • Updated parameters descriptions in keys and secrets README:
    • attributesExp.

Badge: KeyVault: Vaults
Close #783

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@elbatane elbatane added [cat] modules category: modules enhancement New feature or request labels Jan 17, 2022
@elbatane elbatane added this to the v 0.4 milestone Jan 17, 2022
@elbatane @eriqua
Update arm/Microsoft.KeyVault/vaults/.parameters/parameters.json
0042b47 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
eriqua requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work! After reviewing the suggestions could you please run the corresponding pipelines on your branch users/elanzelm/keyvault and paste the status badge to the PR body?

elbatane and others added 6 commits January 18, 2022 17:44
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/secrets/readme.md
7cfa737 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/readme.md
87b9fa2 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/readme.md
6af1df8 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/readme.md
2956eae 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/readme.md
27e628f 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@elbatane @AlexanderSehr
Update arm/Microsoft.KeyVault/vaults/readme.md
9f3905e 
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@github-actions
Copy link

github-actions bot commented Jan 18, 2022 •
edited

Unit Test Results

    1 files  ±    0    1 suites  ±0   59s ⏱️ - 2m 15s
  14 tests  -   21  14 ✔️  - 21      0 💤 ±    0  0 ❌ ±0 
136 runs   - 351  14 ✔️  - 21  122 💤  - 330  0 ❌ ±0 

Results for commit 217d54a. ± Comparison against base commit dd6a5cb.

This pull request removes 35 and adds 14 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apiVersionSets] used resource type [service/apiVersionSets] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis/policies] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis/policies] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/apis] used resource type [service/apis] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/authorizationServers] used resource type [service/authorizationServers] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/backends] used resource type [service/backends] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/caches] used resource type [service/caches] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/identityProviders] used resource type [service/identityProviders] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/namedValues] used resource type [service/namedValues] should use on of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ApiManagement/service/policies] used resource type [service/policies] should use on of the recent API version(s). Currently using [2021-08-01]
…

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/accessPolicies] used resource type [vaults/accessPolicies] should use on of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/keys] used resource type [vaults/keys] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults/secrets] used resource type [vaults/secrets] should use on of the recent API version(s). Currently using [2019-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.KeyVault/vaults] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
…

♻️ This comment has been updated with latest results.

@elbatane
Copy link
Contributor Author

Thanks for the great work! After reviewing the suggestions could you please run the corresponding pipelines on your branch users/elanzelm/keyvault and paste the status badge to the PR body?

Hi Erika, we have added the badge as you mentioned. Thanks

elbatane
elbatane commented Jan 19, 2022
View reviewed changes
Copy link
Contributor Author

@elbatane elbatane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

elbatane
elbatane commented Jan 19, 2022
View reviewed changes
Copy link
Contributor Author

@elbatane elbatane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

eriqua
eriqua approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@elbatane elbatane closed this Jan 20, 2022
@elbatane elbatane reopened this Jan 20, 2022
@elbatane elbatane merged commit 68e7729 into main Jan 20, 2022
@AlexanderSehr AlexanderSehr deleted the users/elanzelm/keyvault branch January 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@elbatane elbatane

@elanzel elanzel

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Set default values to a secure value - Key Vault
4 participants
@elbatane @AlexanderSehr @eriqua @elanzel