Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FW #899

Merged
merged 10 commits into from
Jan 21, 2022
Merged

update FW #899

merged 10 commits into from
Jan 21, 2022

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Jan 18, 2022

Change

minor changes to FW parameters

successful run: Network: AzureFirewalls

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan enabled auto-merge (squash) January 18, 2022 09:40
@rahalan rahalan marked this pull request as draft January 18, 2022 09:47
auto-merge was automatically disabled January 18, 2022 09:47

Pull request was converted to draft

@github-actions
Copy link

github-actions bot commented Jan 21, 2022

Unit Test Results

  1 files  ±    0  1 suites  ±0   16s ⏱️ -59s
  4 tests  -   16  4 ✔️  - 16    0 💤 ±    0  0 ±0 
35 runs   - 197  4 ✔️  - 16  31 💤  - 181  0 ±0 

Results for commit 9d7cca7. ± Comparison against base commit c76225f.

This pull request removes 20 and adds 4 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/jobSchedules] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/modules] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/runbooks] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/schedules] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/softwareUpdateConfigurations] used resource type [automationAccounts/softwareUpdateConfigurations] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/variables] used resource type [automationAccounts/variables] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/azureFirewalls] used resource type [azureFirewalls] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/azureFirewalls] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/azureFirewalls] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/azureFirewalls] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

@rahalan rahalan marked this pull request as ready for review January 21, 2022 11:06
@rahalan rahalan enabled auto-merge (squash) January 21, 2022 11:06
@rahalan rahalan merged commit f14c570 into main Jan 21, 2022
@AlexanderSehr AlexanderSehr deleted the users/rahalan/EnhanceFW branch January 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants