Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disks module #917

Merged
merged 21 commits into from
Jan 24, 2022
Merged

Added disks module #917

merged 21 commits into from
Jan 24, 2022

Conversation

Msanzdelrio
Copy link
Contributor

Change

Feel free to remove this sample text

Thank you for your contribution !

Added disks bicep module. Closes #842

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@Msanzdelrio Msanzdelrio reopened this Jan 21, 2022
@Msanzdelrio Msanzdelrio marked this pull request as ready for review January 21, 2022 11:01
@Msanzdelrio Msanzdelrio self-assigned this Jan 21, 2022
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@Msanzdelrio Msanzdelrio merged commit 3de1e89 into main Jan 24, 2022
@AlexanderSehr AlexanderSehr deleted the users/masanzde/disks-module branch January 25, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Compute Disk module
2 participants